Simen Bekkhus
Simen Bekkhus
Next.js does some weird bundling stuff and have an odd global environment. There might be something off due to that? Probably better to ask in their support channels. I don't...
Making `require`s lazy and migrating to `URL` global should both be fine to land at least. Let's start with that? Then `fetch` is a natural one to target after that....
Happy to take a PR 🙂
https://github.com/siimon/prom-client/releases/tag/v15.1.2
Cool, let's hold off a tiny bit and see if @shappir is able to provide some feedback here 🙂
Have you had time to review this yet, @shappir? 🙂
>perhaps the gains for large strings are significant enough to justify this? choosing a different replacement strategy according to string length? That seems reasonable to me at least 🙂
I'm happy with reducing the API surface (i.e. not land this). However, we can throw an explicit error if an array is passed so the user is aware?
v15 is out with both of your improvements now (thanks a bunch!). Are we ok now, or should we keep this issue open?
Great stuff, looking forward to it! Caching the strings seems like something we can probably do behind an option or some runtime toggle? Or possibly only if a metric has...