Simon Jégou

Results 49 comments of Simon Jégou

My current proposal is mainly to update the `handle_text_elements` function with 1 line: ```diff + text = self.format_paragraph(paragraph) ``` where `format_paragraph` handles formatting. The resulting text can then be used...

@vagenas I pushed a small update to use the `Formatting` class instead of my `style` tuple and handle each hyperlink in a separated "item". It will make easier to return...

@vagenas I removed the `format_text` method and pushed a version that only handles `doc.add_text(label=DocItemLabel.PARAGRAPH, ...)` (so it's still wip). Using the same code as above I get: > *italic* >...

I tried to replace ```python for text, format, hyperlink in paragraph_elements: doc.add_text( label=DocItemLabel.PARAGRAPH, parent=self.parents[level - 1], text=text, formatting=format, hyperlink=hyperlink ) ``` by ```python for text, format, hyperlink in paragraph_elements: inline_fmt...

@vagenas what's wrong with the code I shared were I (try to) use inline groups ? (we posted almost simultaneously) For stripping, my (deleted) `format_text` made sure the leading and...

> Well, you don't want to have a separate inline group for each paragraph element I fixed it thanks, the parent was indeed not on the right side of the...

@vagenas I now handled lists too and updated `tests/data/docx/unit_test_formatting.docx` to have associated tests. For title, headers and equations, I did not change anything. The output looks good: ``` *italic* **bold**...

@vagenas I also added 2 lines for a missing feature: handle headers and footers in MS word document (see #632) . I added the header of the first section and...

@vagenas any feedback ? could you run the tests ? Would be great to merge today if possible