nats-topology-visualiser icon indicating copy to clipboard operation
nats-topology-visualiser copied to clipboard

Published 20 hours ago • verified publisher icon SimCorp

Add docker nats-server to testing environment

Open pizzaluc opened this issue 3 years ago • 3 comments

How was this tested?

  • Step one etc.

Type of change

Please check all boxes that apply to this change below.

Type Applies ✅
Backend
Frontend
Github/Ci/Admin
Documentation required

Checklist

Please follow the checklist below and check all completed items as you work on the PR.

I have..

  • [ ] performed a self-review of my own code
  • [ ] commented my code, particularly in hard-to-understand areas
  • [ ] written documentation
  • [ ] added automated tests
  • [ ] merged dependencies to `develop

pizzaluc avatar Apr 22 '21 16:04 pizzaluc

@pizzaluc anything missing here or is it ready for review?

Maasdamind avatar Apr 28 '21 12:04 Maasdamind

@pizzaluc anything missing here or is it ready for review?

well, nothing is really missing. The test is kinda work in progress, but that is probably better fit for another pull request. So you can review it

pizzaluc avatar Apr 28 '21 12:04 pizzaluc

Looks good to me. How does the changes to EventParser relate to the testing? Don't know this part of the code.

The current code is only able to use the NATS_URL in the .env, i dont know if this is the best way to refactor it, but its necessarry if you wanna spin up a test instance that uses different option parameters

pizzaluc avatar May 06 '21 13:05 pizzaluc