RPGStats icon indicating copy to clipboard operation
RPGStats copied to clipboard

/rpgcheat level options don't account for custom adjusted formula values.

Open HyperSoop opened this issue 1 year ago • 5 comments

Describe the bug The /rpgcheat player skill add/set levels x command uses the default formula values as hardcoded for calculating the amount of XP to give to the recieving player.

To Reproduce Steps to reproduce the behavior:

  1. Change the formula values in config
  2. Give a player a few levels through rpgcheat
  3. The player will recieve less/more levels than what you intended to give.

Expected behavior The player getting the exact amount of levels you intended.

Environment

  • [x] Server
  • [ ] Client
  • [ ] Singleplayer
  • [ ] Lan Server

HyperSoop avatar Aug 23 '22 12:08 HyperSoop

I mean theres literally 0 way this is the issue https://github.com/SilverAndro/RPGStats/blob/master/src/main/java/mc/rpgstats/command/CheatCommand.java#L116

Something else would have to be the issue here, because its calling the exact same method everything else uses

SilverAndro avatar Aug 23 '22 14:08 SilverAndro

I mean theres literally 0 way this is the issue https://github.com/SilverAndro/RPGStats/blob/master/src/main/java/mc/rpgstats/command/CheatCommand.java#L116

Something else would have to be the issue here, because its calling the exact same method everything else uses

It's pretty much what would happen if the level estimation used hardcoded values, so i'm assuming that. The issue is still around, i guess.

HyperSoop avatar Aug 24 '22 09:08 HyperSoop

That command is hacked together haha, it wouldn't surprise me if its got even more bugs

SilverAndro avatar Aug 25 '22 18:08 SilverAndro

Ok so im now seeing this in my dev env and, I have no clue

Ill investigate but this is super bizzare

SilverAndro avatar Sep 22 '22 04:09 SilverAndro