silk icon indicating copy to clipboard operation
silk copied to clipboard

[Proposal] Add a packet format in network module

Open SettingDust opened this issue 1 year ago • 3 comments

Add a packet serial format to network module and use it instead of cbor. And maybe the network should register channel standalone instead of "subchannel" of silk

SettingDust avatar Oct 21 '22 03:10 SettingDust

I am not against this, but before starting to implement this, could you list the benefits of this over Cbor.

jakobkmar avatar Oct 21 '22 21:10 jakobkmar

I am not against this, but before starting to implement this, could you list the benefits of this over Cbor.

Parse packet from other mod or lib.

SettingDust avatar Oct 22 '22 00:10 SettingDust

I guess we could add a quick implementation (requiring opt-in) which uses the Silk nbt serialization and then writes the nbt to the packet (mojang already has a translation there) until we implement serialization to PacketByteBufs directly and make the API stable.

jakobkmar avatar Oct 22 '22 16:10 jakobkmar