silk icon indicating copy to clipboard operation
silk copied to clipboard

feat(nbt): add serializers for tags and item stack

Open SettingDust opened this issue 3 years ago • 6 comments

SettingDust avatar Sep 27 '22 06:09 SettingDust

Is there a code style guideline?

SettingDust avatar Sep 27 '22 06:09 SettingDust

Ready for reviewing

SettingDust avatar Oct 05 '22 01:10 SettingDust

Thanks, will check it out in a few days, ping me if I forget it.

jakobkmar avatar Oct 05 '22 01:10 jakobkmar

Thanks, will check it out in a few days, ping me if I forget it.

Ping

SettingDust avatar Oct 08 '22 10:10 SettingDust

Looking good so far - cloned it locally, I'll add a few commits to this PR and then request a review from f0x.

jakobkmar avatar Oct 10 '22 22:10 jakobkmar

There is something wrong. The BaseTagSerializer require a TagEncoder to fetch the tag. So it can't be used in other formats. So the serializers should be internal or implement a standalone parser for serializer.

SettingDust avatar Oct 19 '22 11:10 SettingDust