ipfs-mini icon indicating copy to clipboard operation
ipfs-mini copied to clipboard

ipns / promise support

Open chmanie opened this issue 8 years ago • 3 comments

Issue Type

  • [x] Feature (https://github.com/silentcicero/ipfs-mini/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description

Sorry, these are actually two feature requests.

  1. How do you feel about promise support? Think: when a callback is passed, the callback will be used, otherwise we return a promise.

  2. Do you think it would be possible to add ipns (publish / resolve) support as well?

I'd happily provide PRs for both of them.

chmanie avatar Aug 02 '17 19:08 chmanie

Would love Promise support, was going to add but never got around to it.

IPNS sounds awesome.

Sounds like you have work to do ;) @chmanie

SilentCicero avatar Aug 02 '17 19:08 SilentCicero

Hey, thanks for the quick answer. Will start right away.

One question: how about browser support? Meaning, shall I assume native Promise support (basically dropping IE) or do we want to include a polyfill?

chmanie avatar Aug 02 '17 20:08 chmanie

Assume native thank you

Sent from my iPhone

On Aug 2, 2017, at 4:51 PM, Christian Maniewski [email protected] wrote:

Hey, thanks for the quick answer. Will start right away.

One question: how about browser support? Meaning, shall I assume native Promise support or do we want to include a polyfill?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

SilentCicero avatar Aug 02 '17 23:08 SilentCicero