Silents-Mechanisms icon indicating copy to clipboard operation
Silents-Mechanisms copied to clipboard

Mixer allows unusable liquids in its inventory

Open Partonetrain opened this issue 5 years ago • 6 comments

Hi again, here's another bug report...

Versions

  • Silent's Mechanisms: 0.6.2+33
  • Silent Lib: 4.4.0+44
  • Forge: 28.1.24
  • Modpack: N/A

Expected Behavior

Mixer doesn't allow unusable liquids in its inventory.

  • (Description)

Actual Behavior

Mixer allows unusable liquids. This would be fine if it was an item-based inventory, but because it's a liquid inventory, you can't take out invalid ingredients, and all you can do is break the block.

  • (Description)

Links/Images

image

(Diesel and lava are not usable in the Mixer)

Not sure if there's an easy way to prevent this with a data-driven recipe system. I understand if this is a wontfix.

Partonetrain avatar Oct 02 '19 00:10 Partonetrain

oh gosh. hit enter too fast. hold on

Didn't realize hitting enter on the title field submits the issue. Sorry about that.

Partonetrain avatar Oct 02 '19 00:10 Partonetrain

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 31 '19 01:12 stale[bot]

I didn't realize I had stale bot on this repo...

SilentChaos512 avatar Dec 31 '19 01:12 SilentChaos512

Made a small change which prevents the mixer from putting the same fluid in multiple tanks. That should help the issue somewhat.

SilentChaos512 avatar Dec 31 '19 21:12 SilentChaos512

I have also managed to put polyethylene back into the mixer and no be able to remove with without moving the mixer.

Perhaps a select output button below each tank icon would assist with other unforeseen items entering it.

McKitten avatar Jan 09 '20 01:01 McKitten

I also encountered this issue and would love a solution for this. In 1.15 I have water in 2 tanks of the mixer somehow and accidently put Diesel in, meaning breaking the block and losing the Diesel is the only real solution.

Best would be obv to check if the fluid is allowed as input for all valid recipes and only allow it if it is. Being able to lock/filter tanks to specific fluids would also work probably. Not sure what is easier for you to implement.

Awesome mod btw, keep up the good work.

davqvist avatar Apr 09 '20 23:04 davqvist