Sildurs-shaders
[1.19.3/Vibrant 1.50] Water texture vanishes if not exposed to direct sunlight or moonlight
Even if Water Texture is turned on, the water texture will not appear on water that isn't exposed to direct sunlight or moonlight. The only difference from if the setting were turned of is that the water will be a bit darker, almost greyish. The water texture shows up just fine on underground water when using Enhanced Default. It only seems to be Vibrant that this is an issue on. The issue affects every version of Vibrant. Note that I also have the water alpha set two points lower than the default setting. In certain areas underground the water is almost totally invisible.
My best guess is that the water texture has somehow been lumped in with effects related to how the sun and moon reflect on water, causing it to be totally absent when those effects are turned off.
Tested with OptiFine 1.19.3 preview 5.
Contrast between water exposed to sunlight and water not. "Water Texture" is turned on. Using Extreme VL.
The same waterfall with "Water Texture" turned off. Using Extreme VL.
How underground water looks with Enhanced Default. This is what it should look like when "Water Texture" is turned on.
The previous stream of water on Vibrant Extreme VL with "Water Texture" turned on.
Modifications I made to "gbuffers_water.fsh" to fix this issue. This should also be repeated for the End (ignoring sunlight). The End has an additional issue where water is half-invisible. That can be fixed by changing "float texvis = 0.5;" to "float texvis = wtexblend;" in the version of the file in the World1 folder. Without this change water in the End looks... bizarre, to say the least.
