Results 86 comments of SignpostMarv

@erayd [this seems to be fine](https://gist.github.com/SignpostMarv/35ebb5220b76b115539b38d06d6d1dc2). There'll be rules to configure to change the behaviour. However.... `@param` tags with no description that are directly match the code are redundant. ```diff...

Would this be for running json schema checks against json input ?

Does airship use json schema for anything? (re: this project coming from airship to begin with)

have updated the link. as for "new", yeah- you wouldn't want to drop support for a phpunit version in a minor/patch release.

@orklah only github is currently supported: https://github.com/psalm/shepherd/blob/c19f58c6a380883617cbb03d84775e868665b2e6/src/PsalmData.php#L19 ```php if (!empty($payload['build']['CI_REPO_OWNER']) && !empty($payload['build']['CI_REPO_NAME']) && empty($payload['build']['CI_PR_REPO_OWNER']) && empty($payload['build']['CI_PR_REPO_NAME']) ) { $repository = new Model\GithubRepository( $payload['build']['CI_REPO_OWNER'], $payload['build']['CI_REPO_NAME'] ); if (($payload['build']['CI_BRANCH'] ?? '') ===...

[pretty much- it's quite common that I'll see data providers & test cases pop up](https://github.com/SignpostMarv/sprintf-exception-factory/commit/b914ebd19de6cfa3baf994c04c7b5ddd9258340a#diff-db03589574d7c5d074966c97658929d9), although it'll also crop up for fixtures & utility classes that're implemented specifically for testing....

> The problem with using coverage data, as I see it, is that it's almost always stale. compare ~filemod time of baseline to~ filemod time of coverage file ~,~ w/...

> I tend to only ever run phpunit with coverage enabled on travis, and then only for a single environment, as it's extremely slow. separate baseline & config files for...

> so why limit it to tests only it depends on if you view this plugin as "stubs out phpunit only" or "makes psalm work nicely with phpunit".

> "makes psalm work nicely with phpunit". i.e. "psalm thinks this method isn't called but psalm/plugin-phpunit knows better"