AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Remove urls tts macos

Open gravelBridge opened this issue 1 year ago • 2 comments

Background

This PR is from https://github.com/Significant-Gravitas/Auto-GPT/pull/3323 By @DevMentat I fixed his code, with formatting and adding his forgotten import (re)

For pr details: https://github.com/Significant-Gravitas/Auto-GPT/pull/3323

Changes

Documentation

Test Plan

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [ ] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

gravelBridge avatar May 17 '23 03:05 gravelBridge

Deployment failed with the following error:

Resource is limited - try again in 3 hours (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar May 17 '23 03:05 vercel[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (Release-v0.4.1@c76c67a). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head 187167b differs from pull request most recent head aa42504. Consider uploading reports for the commit aa42504 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##             Release-v0.4.1    #4260   +/-   ##
=================================================
  Coverage                  ?   70.73%           
=================================================
  Files                     ?       72           
  Lines                     ?     3506           
  Branches                  ?      556           
=================================================
  Hits                      ?     2480           
  Misses                    ?      857           
  Partials                  ?      169           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 17 '23 03:05 codecov[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 18, 2023 6:32am

vercel[bot] avatar May 17 '23 23:05 vercel[bot]

If the urls's are passed to the speech, please edit it in the base.py's say method. That way it's filtered for all tts's

Wladastic avatar May 18 '23 15:05 Wladastic

Deployment failed with the following error:

Resource is limited - try again in 9 hours (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Jun 07 '23 04:06 vercel[bot]

If the urls's are passed to the speech, please edit it in the base.py's say method. That way it's filtered for all tts's

@Wladastic can you expand on that request?

ntindle avatar Jun 07 '23 05:06 ntindle

If the urls's are passed to the speech, please edit it in the base.py's say method. That way it's filtered for all tts's

@Wladastic can you expand on that request?

I think filtering out urls makes more sense to do a few steps up on the abstract class

Wladastic avatar Jun 07 '23 07:06 Wladastic

Deploy Preview for auto-gpt-docs canceled.

Name Link
Latest commit 187167bf008fd306fb75cdd9f3628e2ed4a3f406
Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64899613ebfa080008f58526

netlify[bot] avatar Jun 14 '23 08:06 netlify[bot]

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

Auto-GPT-Bot avatar Jun 14 '23 08:06 Auto-GPT-Bot