AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

add further step to avoid message summary from breaking

Open Wladastic opened this issue 1 year ago • 4 comments

Background

It is already known that message summary could break or overwrite the message history, I encountered a few problems which these two changes fix.

  • making sure that the new_messages are a deep copy as it turned out to break on my runs (less often, but happened)
  • adding extra escaping to make sure json conversion will not break.

Changes

Documentation

Test Plan

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [ ] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

Wladastic avatar May 06 '23 19:05 Wladastic

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 12, 2023 5:13pm

vercel[bot] avatar May 06 '23 19:05 vercel[bot]

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.09 :warning:

Comparison is base (2513178) 60.99% compared to head (29a4336) 60.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3923      +/-   ##
==========================================
- Coverage   60.99%   60.91%   -0.09%     
==========================================
  Files          73       73              
  Lines        3310     3316       +6     
  Branches      542      542              
==========================================
+ Hits         2019     2020       +1     
- Misses       1152     1157       +5     
  Partials      139      139              
Impacted Files Coverage Δ
autogpt/memory_management/summary_memory.py 54.54% <12.50%> (-5.99%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 06 '23 19:05 codecov[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar May 12 '23 19:05 github-actions[bot]

Isnt that obsolete now?

k-boikov avatar May 14 '23 15:05 k-boikov