AutoGPT
AutoGPT copied to clipboard
adding tests to the dev Dockerfile build
Background
Changes
Documentation
Test Plan
PR Quality Checklist
- [x] My pull request is atomic and focuses on a single change.
- [x] I have thoroughly tested my changes with multiple different prompts.
- [x] I have considered potential risks and mitigations for my changes.
- [x] I have documented my changes clearly and comprehensively.
- [x] I have not snuck in any "extra" small tweaks changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
docs | ⬜️ Ignored (Inspect) | May 5, 2023 9:17am |
Er... I did... a.. thing.
Please read the contribution guide: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Contributing
We do not accept PRs without a description.
I put the tests in the dev docker build...
I don't understand why you would do that. Please fill out the pr with the relevant background, as it makes the dockerfile take longer to build. What scenarios would this help with? The PR description allows all the reviewers to have an ability to review your pr.
I don't know your CI/CD platform, perhaps the tests are guaranteed to have run before the Docker image is created?
If not, it seems essential to run the tests before packaging up the docker file...
On Wed, 10 May 2023 at 06:29, Nicholas Tindle @.***> wrote:
I don't understand why you would do that. Please fill out the pr with the relevant background, as it makes the dockerfile take longer to build. What scenarios would this help with? The PR description allows all the reviewers to have an ability to review your pr.
— Reply to this email directly, view it on GitHub https://github.com/Significant-Gravitas/Auto-GPT/pull/3827#issuecomment-1541373385, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKSZTT6U2XTLWB3IS4Q4ZTXFMRRZANCNFSM6AAAAAAXW3LQTE . You are receiving this because you authored the thread.Message ID: @.***>
The Dockerfile is not the place to auto run tests.
OK, When I try to run the docker image, how do I check if the build has passed all tests? It wasn't working out of the box for me, so knowing the tests had been run would be useful.
On Wed, 10 May 2023 at 19:31, k-boikov @.***> wrote:
Closed #3827 https://github.com/Significant-Gravitas/Auto-GPT/pull/3827.
— Reply to this email directly, view it on GitHub https://github.com/Significant-Gravitas/Auto-GPT/pull/3827#event-9214523436, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKSZTTLKZAFPQYVRUVZDQ3XFPNJXANCNFSM6AAAAAAXW3LQTE . You are receiving this because you authored the thread.Message ID: @.*** com>