AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Move construct_full_prompt to prompt.py

Open ph-ausseil opened this issue 1 year ago • 6 comments

** I don't know if wished for current re-arch**

Background

In the current reach people who will be working on the prompt loop, on Agent & on Configuration are different. This commit aim to separate logics that were mixed in AIConfig, to simplify team works by moving construct_full_prompt to prompt.py .

I don't know if it is wish, relevant or of low relevance but it is here and tested (though not though unit tests but practical tests).

Changes

  • Convert the method to a function where an object AIConfig is passed as argument
  • Move the function construct_full_prompt from ai_config.py to prompt.py
  • Imports

Documentation

The method was not documented in AIConfig DocString so no change have been made.

Test Plan

Run the application several times.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

ph-ausseil avatar May 03 '23 05:05 ph-ausseil

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 6, 2023 0:04am

vercel[bot] avatar May 03 '23 05:05 vercel[bot]

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions[bot] avatar May 06 '23 11:05 github-actions[bot]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions[bot] avatar May 06 '23 11:05 github-actions[bot]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions[bot] avatar May 06 '23 11:05 github-actions[bot]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions[bot] avatar May 06 '23 11:05 github-actions[bot]