AutoGPT
AutoGPT copied to clipboard
Make sdwebui tests pass (when SD is running)
Background
Looking for what literal to put in IMAGE_PROVIDER
, I found an inconsistent literal in a test, and made more changes to get the SD xfail
tests to instead pass.
Changes
- Correct literal argument
sd_webui
tosdwebui
intest_sd_webui
. - Make generated-image path check work in Windows as well.
- Change passing tests requiring SD to be running from
xfail
topass
.
Documentation
Explanations added for the tests to be skipped, replacing the explanations for xfail. No other documentation should be needed as the changes are small and just fix tests.
Test Plan
- With SD running, uncommented
pytest.mark.skip
and got successful runs fortest_sd_webui
andtest_sd_webui_negative_prompt
.
I have not tested this change on other OS:es but all paths that previously worked should still work (split(":") -> split(":",1)
)
PR Quality Checklist
- [X] My pull request is atomic and focuses on a single change.
- [ ] I have thoroughly tested my changes with multiple different prompts.
- [X] I have considered potential risks and mitigations for my changes.
- [X] I have documented my changes clearly and comprehensively.
- [X] I have not snuck in any "extra" small tweaks changes
Tests have been made to work. No new tests need to be added to test that the tests work.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 13, 2023 8:02pm |
This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!
For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting
Codecov Report
Patch coverage has no change and project coverage change: -0.13
:warning:
Comparison is base (
900de5f
) 60.96% compared to head (99239b5
) 60.84%.
Additional details and impacted files
@@ Coverage Diff @@
## master #3721 +/- ##
==========================================
- Coverage 60.96% 60.84% -0.13%
==========================================
Files 73 73
Lines 3315 3315
Branches 543 543
==========================================
- Hits 2021 2017 -4
- Misses 1155 1160 +5
+ Partials 139 138 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.