AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Fix deserializing bad input third attempt

Open ido777 opened this issue 1 year ago • 1 comments

Background

Fixes #778, surrogates errors

Changes

  1. added lib to requirments.txt
  2. changed the insertion of the text to the list to be fixed before adding it to the list
  3. added test of with problematic test that creates an encoding error but pass the addition to the cache with no error

Documentation

Test Plan

Added dedicated test

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

ido777 avatar May 02 '23 05:05 ido777

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 2, 2023 5:38am

vercel[bot] avatar May 02 '23 05:05 vercel[bot]

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar May 25 '23 18:05 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 14 '23 21:07 github-actions[bot]

Deploy Preview for auto-gpt-docs canceled.

Name Link
Latest commit ac208f2f51a12c4614303aca6feadad79c068001
Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64b1c1e0ecef44000851d29f

netlify[bot] avatar Jul 14 '23 21:07 netlify[bot]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (376ecf0) 51.00% compared to head (ac208f2) 51.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3666      +/-   ##
==========================================
+ Coverage   51.00%   51.02%   +0.02%     
==========================================
  Files         118      118              
  Lines        4884     4886       +2     
  Branches      643      643              
==========================================
+ Hits         2491     2493       +2     
  Misses       2212     2212              
  Partials      181      181              
Impacted Files Coverage Δ
autogpt/memory/vector/memory_item.py 86.66% <100.00%> (+0.30%) :arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 14 '23 21:07 codecov[bot]

Better late than never. :')

Thanks @ido777!

Pwuts avatar Jul 14 '23 22:07 Pwuts