AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Refactor milvus tests to conform with pytest

Open rihp opened this issue 2 years ago • 4 comments

Background

This tests werent being ran before since the file was not named properly, i was unable to test them locally because of not having the milvus server locally

Changes

refactored the module to use pytest instead of unittest

Documentation

in the skipping marks for pytest

Test Plan

running pytest

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [ ] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

rihp avatar Apr 30 '23 17:04 rihp

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 30, 2023 5:48pm

vercel[bot] avatar Apr 30 '23 17:04 vercel[bot]

Codecov Report

Patch coverage has no change and project coverage change: +3.88 :tada:

Comparison is base (aebe891) 56.46% compared to head (e8d1510) 60.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3589      +/-   ##
==========================================
+ Coverage   56.46%   60.34%   +3.88%     
==========================================
  Files          65       69       +4     
  Lines        3018     3099      +81     
  Branches      507      513       +6     
==========================================
+ Hits         1704     1870     +166     
+ Misses       1175     1098      -77     
+ Partials      139      131       -8     

see 38 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 30 '23 17:04 codecov[bot]

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar May 13 '23 14:05 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar May 25 '23 18:05 github-actions[bot]

The Milvus vector store backend was (temporarily) removed in #4208. For more info, see #4280.

Still, thanks for taking the time to submit this! We do appreciate the interest and the effort, and I'm sorry we couldn't process this earlier.

Pwuts avatar Jul 14 '23 21:07 Pwuts