AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Fix "unsafe repository" warning after creating devcontainer, initializes repository with proper user.

Open johnseth97 opened this issue 2 years ago • 5 comments

Background

When opening the repository in a devcontainer, the repository is not initialized with git until the user runs a command to trust the repository, even though the repository was trusted earlier on the machine. This is because such settings don't get passed into the container.

Changes

Added "postCreateCommand": "git config --global --add safe.directory /workspace/Auto-GPT", and changed the UID/GID to the default 1000. Enabled PyTest and Github CLI

Documentation

In code comments

Test Plan

Built the docker container, made this PR from it.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

johnseth97 avatar Apr 30 '23 06:04 johnseth97

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2023 1:57am

vercel[bot] avatar Apr 30 '23 06:04 vercel[bot]

Codecov Report

Patch and project coverage have no change.

Comparison is base (479c746) 59.89% compared to head (03f5d95) 59.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3564   +/-   ##
=======================================
  Coverage   59.89%   59.89%           
=======================================
  Files          69       69           
  Lines        3209     3209           
  Branches      535      535           
=======================================
  Hits         1922     1922           
  Misses       1149     1149           
  Partials      138      138           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 30 '23 06:04 codecov[bot]

It may be worth adding extensions:

 "customizations": {
    // Configure properties specific to VS Code.
    "vscode": {
      // Set *default* container specific settings.json values on container create.
      "settings": {
        "python.defaultInterpreterPath": "/usr/local/bin/python"
	},
	"extensions": [
		"ms-python.python",
		"VisualStudioExptTeam.vscodeintellicode",
		"ms-python.vscode-pylance",
		"ms-python.black-formatter",
		"ms-python.isort",
		"GitHub.vscode-pull-request-github",
		"GitHub.copilot",
		"github.vscode-github-actions"
	]
    }
  },

ntindle avatar May 03 '23 02:05 ntindle

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

@ntindle I recommend merging.(I'm not able to do so)

I added two follow-up PRs #4180 and #4181 to address your comments above.

lc0rp avatar May 14 '23 07:05 lc0rp

@desojo Please do not use master, switch you changes to another branch remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: At least 1 approving review is required by reviewers with write access.
To https://github.com/desojo/Auto-GPT.git

k-boikov avatar May 18 '23 21:05 k-boikov

Closed in favor of https://github.com/Significant-Gravitas/Auto-GPT/pull/4180

k-boikov avatar May 18 '23 21:05 k-boikov