AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

fix connection bug for zilliz uri on milvus

Open chyezh opened this issue 2 years ago • 2 comments

Background

A new bug was introduced by #2127

Changes

fix new bug in MilvusMemory construction.

Documentation

Test Plan

  • pass manually test

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

chyezh avatar Apr 26 '23 02:04 chyezh

Codecov Report

Patch coverage has no change and project coverage change: -7.98 :warning:

Comparison is base (02f546d) 51.22% compared to head (c4c3e73) 43.25%.

:exclamation: Current head c4c3e73 differs from pull request most recent head d61f31d. Consider uploading reports for the commit d61f31d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3278      +/-   ##
==========================================
- Coverage   51.22%   43.25%   -7.98%     
==========================================
  Files          65       65              
  Lines        2975     2973       -2     
  Branches      502      502              
==========================================
- Hits         1524     1286     -238     
- Misses       1331     1612     +281     
+ Partials      120       75      -45     
Impacted Files Coverage Δ
autogpt/memory/milvus.py 3.38% <0.00%> (ø)

... and 18 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 26 '23 02:04 codecov[bot]

@Pwuts Hi, It's the bugfix commit for the fatal bug introduced by #2127. The bug is already discussed in another PR https://github.com/Significant-Gravitas/Auto-GPT/pull/3084#issuecomment-1520244111 But the merging of #3084 is blocked because of conflict of test with #1725. So I will submit the related test of Milvus after #1725 is merged, and produce this PR for the bugfix separately. I think that this fatal bug will be fixed as soon as possible.

chyezh avatar Apr 26 '23 15:04 chyezh

Hi, @Pwuts, Could you please review and fix this fatal error? :) User using Zilliz Cloud will encounter this issue. There are only 7 lines of code changes here, but it is very important to us.

chyezh avatar Apr 27 '23 00:04 chyezh

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:56am

vercel[bot] avatar Apr 27 '23 00:04 vercel[bot]