AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Add 1/0 as alternative to y/n

Open edcohen08 opened this issue 1 year ago • 4 comments

Background

Targets issue #766 to make auto-gpt more accessible internationally

Changes

Allows 1/0 as alternative inputs to y/n

Documentation

Documented in the readme

Test Plan

I started writing a test for the interaction loop but was struggling with all of the mocking involved, tested running it and it worked fine

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

edcohen08 avatar Apr 25 '23 01:04 edcohen08

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.02 :tada:

Comparison is base (94dc6f1) 54.83% compared to head (2878f74) 54.86%.

:exclamation: Current head 2878f74 differs from pull request most recent head d27131b. Consider uploading reports for the commit d27131b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
+ Coverage   54.83%   54.86%   +0.02%     
==========================================
  Files          65       65              
  Lines        3018     3020       +2     
  Branches      508      508              
==========================================
+ Hits         1655     1657       +2     
  Misses       1227     1227              
  Partials      136      136              
Impacted Files Coverage Δ
autogpt/agent/agent.py 45.39% <0.00%> (ø)
autogpt/prompts/prompt.py 56.60% <ø> (ø)
autogpt/utils.py 67.05% <0.00%> (ø)
autogpt/config/config.py 76.82% <100.00%> (+0.31%) :arrow_up:
autogpt/plugins.py 73.88% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 25 '23 01:04 codecov[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 25 '23 05:04 github-actions[bot]

  1. #766 is a pull request, not an issue
  2. This PR is basically a copy of that PR, but without any attribution. 👎🏼
  3. Because of 2., this PR is subject to the same request for changes.

Pwuts avatar Apr 26 '23 08:04 Pwuts

An honest mistake, I just started typing the title and clicked what came up first, I meant to link #753
Given 766 exists first I can close this or happy to finish it but give the right credit

edcohen08 avatar Apr 26 '23 13:04 edcohen08

If you can make the requested adjustments (moving this to config ipv hard-coding extra y/n characters) I'd be happy to merge this. :)

Pwuts avatar Apr 26 '23 20:04 Pwuts

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 7:23pm

vercel[bot] avatar Apr 27 '23 00:04 vercel[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 27 '23 00:04 github-actions[bot]