AutoGPT
AutoGPT copied to clipboard
Fix git clone to conform to validation.
Background
In the most recent change, git clone no longer adheres to the URL validation schema, causing positional argument errors.
Changes
Changed repository_url
to url
to adhere to the URL validation schema.
Documentation
Updated the function documentation to say url
instead.
Test Plan
Same tests as before.
PR Quality Checklist
- [X] My pull request is atomic and focuses on a single change.
- [X] I have thoroughly tested my changes with multiple different prompts.
- [X] I have considered potential risks and mitigations for my changes.
- [X] I have documented my changes clearly and comprehensively.
- [X] I have not snuck in any "extra" small tweaks changes
Codecov Report
Patch coverage has no change and project coverage change: -8.53
:warning:
Comparison is base (
29284a5
) 49.52% compared to head (6019a55
) 41.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #3150 +/- ##
==========================================
- Coverage 49.52% 41.00% -8.53%
==========================================
Files 64 64
Lines 2946 2946
Branches 497 497
==========================================
- Hits 1459 1208 -251
- Misses 1365 1679 +314
+ Partials 122 59 -63
Impacted Files | Coverage Δ | |
---|---|---|
autogpt/commands/git_operations.py | 0.00% <0.00%> (ø) |
... and 15 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
lgtm! out of curiosity did you actually get an error? i thought that even though it's called url in the wrapper function because that's a positional arg and not a kwarg that it doesn't actually matter what the url argument is called, just that it comes first
Yep, I did! I received an error stating that the positional argument url
was missing.
Nice, great fix!
On Mon, Apr 24, 2023 at 5:34 PM Steven Baumann @.***> wrote:
lgtm! out of curiosity did you actually get an error? i thought that even though it's called url in the wrapper function because that's a positional arg and not a kwarg that it doesn't actually matter what the url argument is called, just that it comes first
Yep, I did! I received an error stating that the positional argument url was missing.
— Reply to this email directly, view it on GitHub https://github.com/Significant-Gravitas/Auto-GPT/pull/3150#issuecomment-1520858139, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHTWBOBVPZYDNWPKGKYGI7DXC3WW7ANCNFSM6AAAAAAXJ6I53U . You are receiving this because you commented.Message ID: @.***>
-- Eddie Cohen, Software Engineer Lightmatter https://lightmatter.com/ @.***
Codecov Report
Patch and project coverage have no change.
Comparison is base (
b8478a9
) 57.19% compared to head (2d99230
) 57.19%.
Additional details and impacted files
@@ Coverage Diff @@
## master #3150 +/- ##
=======================================
Coverage 57.19% 57.19%
=======================================
Files 68 68
Lines 3079 3079
Branches 516 516
=======================================
Hits 1761 1761
Misses 1180 1180
Partials 138 138
Impacted Files | Coverage Δ | |
---|---|---|
autogpt/commands/git_operations.py | 0.00% <0.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
docs | ⬜️ Ignored (Inspect) | Apr 29, 2023 0:42am |
If one of you has the time, please also submit a PR adding a test for clone_repository
so this doesn't happen again :)