AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

fix milvus_memory_test and fix milvus connect bug

Open chyezh opened this issue 2 years ago • 11 comments

Background

I found that pymilvus was removed in requirements for unknown reasons, for that,milvus unit test was skipped in workflow. And because of the lack of manual test and uint test after last change on #2127, a new bug was introduced.

Changes

  • Add pymilvus to requirements
  • Fix milvus_memory_test.py, only skip part of it when milvus memory backend is not ready on test environment. At least The code before connecting to the milvus backend can be covered by test.
  • fix new bug in MilvusMemory construction.

Documentation

Test Plan

  • pass manually test
  • pass unit test in milvus ready environment.
  • pass unit test in zilliz cloud environment.
  • skip unit test in no milvus backend environment.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

chyezh avatar Apr 24 '23 03:04 chyezh

Codecov Report

Patch coverage has no change and project coverage change: -7.33 :warning:

Comparison is base (f8dfedf) 49.65% compared to head (644528f) 42.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3084      +/-   ##
==========================================
- Coverage   49.65%   42.32%   -7.33%     
==========================================
  Files          64       64              
  Lines        3021     3022       +1     
  Branches      505      505              
==========================================
- Hits         1500     1279     -221     
- Misses       1401     1675     +274     
+ Partials      120       68      -52     
Impacted Files Coverage Δ
autogpt/commands/web_selenium.py 0.00% <0.00%> (ø)
autogpt/memory/milvus.py 40.67% <0.00%> (+37.28%) :arrow_up:

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 24 '23 03:04 codecov[bot]

HI, @Pwuts @ntindle Here is unit test fixing of #2127 and a bug introduced by previous PR is also fixed in this PR. I think that it can be merged shortly. looking forward to your reply.

chyezh avatar Apr 24 '23 03:04 chyezh

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 24 '23 13:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 24 '23 13:04 github-actions[bot]

Hi @Pwuts, Here is a bug introduced by PR #2127 that was merged yesterday. Can we shortly merge to fix it? image image self.address is set to None, but still be used.

@ntindle Unit test of milvus memory was also fixed. It seems to be a problem with Codeconv here, as new tests have been added, but the coverage has actually decreased.

chyezh avatar Apr 24 '23 14:04 chyezh

I'd love to test this, but I can't get Zilliz to create my account. I keep getting internal server errors when making the account with GitHub. I'm going to let another maintainer pick this up

ntindle avatar Apr 24 '23 22:04 ntindle

Codecov error is known

ntindle avatar Apr 25 '23 06:04 ntindle

Hi, @Pwuts could we merge this PR and fix the bug? :)

chyezh avatar Apr 25 '23 15:04 chyezh

I'd love to test this, but I can't get Zilliz to create my account. I keep getting internal server errors when making the account with GitHub. I'm going to let another maintainer pick this up

Hi @ntindle what's the major issue your are facing?

xiaofan-luan avatar Apr 25 '23 23:04 xiaofan-luan

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar May 13 '23 14:05 github-actions[bot]

Since all third-party memory backends have been removed, this is no longer applicable. Still, thanks for submitting! At some point we will probably have Milvus integration again, and we'll try to make sure it works from the get go. ;-)

Pwuts avatar Sep 08 '23 12:09 Pwuts