AutoGPT
AutoGPT copied to clipboard
Fixed a bug in the function that tries to enclose the json properties with double quotes
Background
The existing function to add quotes to the property name has an issue. It contains a simple regex that matches to content already inside quotes. The existing function would change the property value "something http://link.to/" to "something "http":link.to"
I have updated the regex to avoid matching to content enclosed by quotes.
Changes
Test Plan
The JSON response from openAI should contain properties missing the double quotes
PR Quality Checklist
- [x] My pull request is atomic and focuses on a single change.
- [x ] I have thoroughly tested my changes with multiple different prompts.
- [x] I have considered potential risks and mitigations for my changes.
- [x] I have documented my changes clearly and comprehensively.
- [x] I have not snuck in any "extra" small tweaks changes
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.
Conflicts have been resolved! π A maintainer will review the pull request shortly.
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.
The latest updates on your projects. Learn more about Vercel for Git βοΈ
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs | β¬οΈ Ignored (Inspect) | Jun 8, 2023 6:39am |
Conflicts have been resolved! π A maintainer will review the pull request shortly.
@nponeccop, any chance to have this reviewed again?
This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!
For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.
Conflicts have been resolved! π A maintainer will review the pull request shortly.
Codecov Report
Patch coverage: 50.00% and no project coverage change.
Comparison is base (
1e851ba) 69.67% compared to head (828d5f1) 69.67%.
Additional details and impacted files
@@ Coverage Diff @@
## master #2188 +/- ##
=======================================
Coverage 69.67% 69.67%
=======================================
Files 72 72
Lines 3558 3558
Branches 569 569
=======================================
Hits 2479 2479
Misses 890 890
Partials 189 189
| Impacted Files | Coverage Ξ | |
|---|---|---|
| autogpt/json_utils/json_fix_general.py | 52.38% <50.00%> (ΓΈ) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.
Thanks for submitting! The help in fixing our JSON issues is much appreciated, even though we couldn't include all submitted PRs in the process. We have since changed the way we instruct the LLM on the response format (using a JSON schema), so this PR is no longer necessary. If you are still interested in contributing, be sure to shoot us a message on Discord! :)