AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Driver customization options

Open thehunmonkgroup opened this issue 2 years ago • 21 comments

Background

Basically, the way the selenium drivers are set up doesn't allow flexibility for older installs (I'm on Debian 10 headless), or customizing the driver options to work around issues (like my requirement for the --no-sandbox option).

Changes

This adds two new configuration variables:

  • DRIVER_EXECUTABLE_PATH: Allows specifying a custom driver binary.
  • DRIVER_EXTRA_OPTIONS: Allows passing other needed options to the driver.

Documentation

They are clearly documented with comments in .env.template

Test Plan

The changes are quite simple, I didn't do any testing beyond making sure the features work as intended, and that no errors happen when the new configuration options are not used.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

thehunmonkgroup avatar Apr 17 '23 02:04 thehunmonkgroup

@thehunmonkgroup There are conflicts now

nponeccop avatar Apr 17 '23 11:04 nponeccop

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 16:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 16:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 17 '23 17:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 18 '23 23:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 18 '23 23:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 18 '23 23:04 github-actions[bot]

Hello - First comment on GitHub! I've installed Python 3.10 on Linux / Ubuntu with the latest stable release of Auto-GPT. It is working good except for the browse_website command, which is currently throwing the following error:

System: Command browse_website returned: Error: Message: unknown error: Chrome failed to start: crashed.
  (chrome not reachable)
  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
Stacktrace:
#0 0x7fbd90bfbfe3 <unknown>
#1 0x7fbd9093ad36 <unknown>
#2 0x7fbd90963b20 <unknown>
#3 0x7fbd9095fa9b <unknown>
#4 0x7fbd909a1af7 <unknown>
#5 0x7fbd909a111f <unknown>
#6 0x7fbd90998693 <unknown>
#7 0x7fbd9096b03a <unknown>
#8 0x7fbd9096c17e <unknown>
#9 0x7fbd90bbddbd <unknown>
#10 0x7fbd90bc1c6c <unknown>
#11 0x7fbd90bcb4b0 <unknown>
#12 0x7fbd90bc2d63 <unknown>
#13 0x7fbd90b95c35 <unknown>
#14 0x7fbd90be6138 <unknown>
#15 0x7fbd90be62c7 <unknown>
#16 0x7fbd90bf4093 <unknown>
#17 0x7fbd904b5609 <unknown>

It sounds like this branch might resolve the issue, but I figured I'd add my two cents just in case it's helpful!

BTCompKSU avatar Apr 19 '23 03:04 BTCompKSU

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 19 '23 06:04 github-actions[bot]

Can we get this in? It's a simple patch that I've had to fix conflicts on several times, would really like to close this sucker out.

thehunmonkgroup avatar Apr 19 '23 06:04 thehunmonkgroup

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 24 '23 13:04 github-actions[bot]

@thehunmonkgroup Please, fix conflict. Squash (to a single commit) and rebase to master.

superherointj avatar Apr 25 '23 12:04 superherointj

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 25 '23 19:04 github-actions[bot]

Done. I really hope you guys get this in now, this is the fourth time I've fixed merge conflicts, probably not gonna do any more of that.

thehunmonkgroup avatar Apr 25 '23 19:04 thehunmonkgroup

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 27 '23 17:04 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 28, 2023 3:46am

vercel[bot] avatar Apr 28 '23 03:04 vercel[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 28 '23 03:04 github-actions[bot]

At this point, I have to be approaching the most times anyone has resolved a conflict on a PR for this project, right??

thehunmonkgroup avatar Apr 28 '23 03:04 thehunmonkgroup

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

At this point, I have to be approaching the most times anyone has resolved a conflict on a PR for this project, right??

Note this looks like a useful change to be reviewed/integrated despite the ongoing re-arch effort, it's primarily config-level, with very few code changes (and those primarily are about adding selenium options for people on older systems). So definitely do consider for review/integration to help close some PRs. Thanks

Boostrix avatar May 07 '23 07:05 Boostrix

I don't agree with merging right now.

https://github.com/Significant-Gravitas/Auto-GPT/pull/1988#issuecomment-1537340291

anonhostpi avatar May 07 '23 07:05 anonhostpi

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar May 25 '23 18:05 github-actions[bot]

Is it worth it to keep updating this PR? Could it still be under consideration? Are y'all done with the big refactor?

thehunmonkgroup avatar May 25 '23 19:05 thehunmonkgroup