AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

add edge to browser options for selenium

Open Amraki opened this issue 1 year ago • 14 comments

Background

I received errors related to selenium not locating the default chrome binary. Instead of installing it and possibly troubleshooting file paths, I wanted to use my current browser.

Changes

Added 'edge' as a browser option for selenium.

Documentation

Updated .env.template to reflect the additional option. Kept changes consistent with existing code.

Test Plan

Auto-GPT has opened a new MS Edge browser instance, navigated to the provided URL, scraped the content, and closed the browser instance. This has successfully occurred in multiple runs without related errors.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

Amraki avatar Apr 16 '23 19:04 Amraki

While you're at it can you also add opera? Just to complete everything lol

sadmuphin avatar Apr 16 '23 19:04 sadmuphin

I can look it up, but I can't test it myself.

Also, I just noticed a few changes that aren't mine. Mostly likely from the last pull I did. Still new to PR's and first time doing it from VS Code. I'll try to fix.

Amraki avatar Apr 16 '23 19:04 Amraki

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 18:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 18:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 17 '23 23:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 18 '23 23:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 18 '23 23:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 18 '23 23:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 19 '23 05:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 19 '23 17:04 github-actions[bot]

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

While you're at it can you also add opera? Just to complete everything lol

Not recommended. Create a separate PR. See:

image

anonhostpi avatar May 05 '23 03:05 anonhostpi

Note this looks like a useful change to be reviewed/integrated despite the ongoing re-arch effort, it's primarily config-level, with very few code changes. So definitely do consider for review/integration to help close some PRs. Thanks

Boostrix avatar May 07 '23 07:05 Boostrix

While, I do agree that this probably has no affects on the rearch, as chrome is available at the moment, I think this is low priority until after the rearch.

This could also open a whole new can of worms with webdriver. This repo keeps running into problems with getting chromedriver to cooperate. Adding msedgedriver to the mix probably isn't a good idea right now.

Though I do think we still inevitably need this. I just feel like a better time to propose this would be after the rearch and after the issues with chromedriver have been mitigated.

anonhostpi avatar May 07 '23 07:05 anonhostpi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2023 9:02pm

vercel[bot] avatar May 13 '23 20:05 vercel[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar May 13 '23 20:05 github-actions[bot]

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03 :warning:

Comparison is base (2f7beeb) 60.84% compared to head (3a18a16) 60.81%.

:exclamation: Current head 3a18a16 differs from pull request most recent head 5db3035. Consider uploading reports for the commit 5db3035 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
- Coverage   60.84%   60.81%   -0.03%     
==========================================
  Files          73       73              
  Lines        3315     3318       +3     
  Branches      543      544       +1     
==========================================
+ Hits         2017     2018       +1     
- Misses       1160     1161       +1     
- Partials      138      139       +1     
Impacted Files Coverage Δ
autogpt/commands/web_selenium.py 84.26% <33.33%> (-1.78%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 13 '23 20:05 codecov[bot]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions[bot] avatar May 13 '23 21:05 github-actions[bot]

Closing in favor of https://github.com/Significant-Gravitas/Auto-GPT/pull/3058

k-boikov avatar May 13 '23 21:05 k-boikov