AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Feature/pathlib for ai config

Open Back2Basics opened this issue 1 year ago • 3 comments

Background

formerly PR #647. I put this change in and before the PR could be accepted the file changed format and moved to a different folder.

Changes

pathlib.Path instead of os.path for readability and removing a try/except as a bonus.

Test Plan

Tried it with 2 different runs of autogpt one with and without a ai_settings.yaml file.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

Back2Basics avatar Apr 15 '23 06:04 Back2Basics

@Back2Basics, could you kindly clarify whether this is a reiteration of an earlier pull request? If so, could you please add the corresponding number to the "Background" section of the pull request description? Thank you.

There are new conflicts, too

nponeccop avatar Apr 15 '23 06:04 nponeccop

Done. Let me know if there is more. I don't see any merge conflicts other than a title I put on a commit.

On Apr 14, 2023, at 23:59, nponeccop @.***> wrote:

@Back2Basics https://github.com/Back2Basics, could you kindly clarify whether this is a reiteration of an earlier pull request? If so, could you please add the corresponding number to the "Background" section of the pull request description? Thank you.

— Reply to this email directly, view it on GitHub https://github.com/Significant-Gravitas/Auto-GPT/pull/1492#issuecomment-1509599006, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGKWBBLDEDVUGJLILFHH7DXBJBOBANCNFSM6AAAAAAW7HEHPI. You are receiving this because you were mentioned.

Back2Basics avatar Apr 15 '23 07:04 Back2Basics

@Back2Basics There are conflicts now

nponeccop avatar Apr 15 '23 13:04 nponeccop

I'm looking forward to this. This is gonna solve a bug I'm hitting

dschonholtz avatar Apr 15 '23 21:04 dschonholtz

I'm looking forward to this. This is gonna solve a bug I'm hitting

Thank you for the note. You are one other person's comments made this worth it.

Back2Basics avatar Apr 17 '23 01:04 Back2Basics