AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Separate memory index for Pinecone, Redis and local cache memory backends

Open Tymec opened this issue 1 year ago • 9 comments

Background

This change proposes to replace memory_index which is used in both Redis and LocalCache memory backends, with separate config options for each memory backend. This would make the code more flexible and configurable, as well as consistent with other memory backends.

Changes

  • Create redis_index, local_cache_index and pinecone_index config options for each memory backend
  • Remove memory_index config option
  • Remove hardcoded table name in Pinecone and replace it with pinecone_index

Documentation

Test Plan

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [ ] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

Tymec avatar Apr 15 '23 01:04 Tymec

Since both Redis and Local memory types shared the same memory index, I assumed that's what was meant. Having each memory type have it's own memory index does sound like a better overall approach. Either way, I implemented the changes and now each memory type (except NoMemory) should have it's own index.

Tymec avatar Apr 15 '23 07:04 Tymec

@Tymec There are conflicts now

nponeccop avatar Apr 15 '23 13:04 nponeccop

Run flake8 autogpt/ tests/ --select E303,W293,W291,W292,E305,E231,E302 autogpt/config/config.py:85:1: W293 blank line contains whitespace

richbeales avatar Apr 15 '23 15:04 richbeales

Conflicting files autogpt/config/config.py autogpt/memory/redismem.py

richbeales avatar Apr 15 '23 17:04 richbeales

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 19 '23 17:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 19 '23 19:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 19 '23 23:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 20 '23 07:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 23 '23 16:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 24 '23 19:04 github-actions[bot]

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.36 :tada:

Comparison is base (4a20616) 41.66% compared to head (e927f48) 42.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
+ Coverage   41.66%   42.03%   +0.36%     
==========================================
  Files          65       65              
  Lines        3029     3031       +2     
  Branches      507      507              
==========================================
+ Hits         1262     1274      +12     
+ Misses       1702     1692      -10     
  Partials       65       65              
Impacted Files Coverage Δ
autogpt/memory/pinecone.py 28.57% <0.00%> (ø)
autogpt/memory/redismem.py 29.23% <0.00%> (ø)
autogpt/config/config.py 75.16% <100.00%> (+0.32%) :arrow_up:
autogpt/memory/local.py 95.91% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 24 '23 20:04 codecov[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 27 '23 01:04 github-actions[bot]

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-