AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

I have started adding support for multiple languages in our applicati…

Open reise69 opened this issue 2 years ago • 6 comments

Background

The need for search results in languages other than English and the ability to search the SERP in languages other than English has been identified as a valuable feature addition to our application. To address this need, I have implemented the --lang and --searchregion parameters for our script.

Changes

Added two parameters for script execution: --lang and --searchregion
Example usage: python scripts/main.py --lang fr --searchregion fr-fr

Documentation

The newly added parameters --lang and --searchregion have been documented within the script using inline comments.

 python scripts/main.py --lang fr --searchregion fr-fr

Test Plan

I have tested this functionality with french and english and somes prompt exemples. The application retrieves search results in the specified language and region as expected. Further testing will be conducted to ensure compatibility with other existing features.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [ ] I have documented my changes clearly and comprehensively.
  • [ ] I have not snuck in any "extra" small tweaks changes

reise69 avatar Apr 14 '23 12:04 reise69

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

I don't think the project is looking to support localization yet. At least definitely not until the re-arch. See https://github.com/Significant-Gravitas/Auto-GPT/labels/re-arch

anonhostpi avatar May 05 '23 04:05 anonhostpi

@anonhostpi said it, we advise to wait until the re-arch dust settles before taking on i18n. We'll be happy to see this kind of contribution then!

Closing, and labeling as fridge so we don't forget

Pwuts avatar Jun 14 '23 23:06 Pwuts