AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Message about Pinecone initializing

Open Ashutoshkataria19 opened this issue 1 year ago • 16 comments

Added a message: "Connecting Pinecone. This may take some time..." close #987

Background

If the Pinecone index setup takes a noticeable amount of time, the console just stops. It is necessary to notify the user that the index is being configured now and this may take some time.

Changes

Added a message: "Connecting Pinecone. This may take some time..."

Documentation

Test Plan

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

Ashutoshkataria19 avatar Apr 13 '23 21:04 Ashutoshkataria19

please I need some help as this is my first pull request I read logger.py and I can think of these three approaches please let me know if I am wrong

1st approach I can use logger.debug("Connecting Pinecone. This may take some time...")

but this message is of level = logging.info

2nd approach first I should define something like def info( self, message, title='', title_color='', ): self._log(title, title_color, message, logging.INFO) in logger.py and then use logger.info("Connecting Pinecone. This may take some time...") in pinecone.py

3rd approach or should I directly go with logger._log('', '', "Connecting Pinecone. This may take some time...", logging.INFO)

Ashutoshkataria19 avatar Apr 14 '23 12:04 Ashutoshkataria19

@p-i- @richbeales Could you assist him?

nponeccop avatar Apr 14 '23 13:04 nponeccop

Waiting for some hint. At least tell me if I am thinking in right direction.

Ashutoshkataria19 avatar Apr 16 '23 17:04 Ashutoshkataria19

Maybe @BillSchumacher ?

nponeccop avatar Apr 16 '23 17:04 nponeccop

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 18 '23 07:04 github-actions[bot]

You accidentally deleted the file. Revert that commit please. You can do it from GitHub desktop UI or switch to your branch and run

git revert 70dc1af4c8322be4033df2920a85c8e25688f3ae

and then commit and push that

ntindle avatar Apr 18 '23 08:04 ntindle

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 18 '23 08:04 github-actions[bot]

You accidentally deleted the file. Revert that commit please. You can do it from GitHub desktop UI or switch to your branch and run

git revert 70dc1af4c8322be4033df2920a85c8e25688f3ae

and then commit and push that

thanks for pointing out

Ashutoshkataria19 avatar Apr 18 '23 08:04 Ashutoshkataria19

I apologize to everyone for any problems or difficulties I may have caused and I appreciate your time and patience.

Ashutoshkataria19 avatar Apr 18 '23 08:04 Ashutoshkataria19

@Ashutoshkataria19 the PRs is outdated, the file is now autogpt/memory/pinecone.py not scripts/memory/pinecone.py please rebase.

k-boikov avatar Apr 18 '23 11:04 k-boikov

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 18 '23 20:04 github-actions[bot]

I attempted to rebase my branch, hoping that updating my fork would resolve the issues. However, during the process, all the commits were inadvertently deleted, and the pull request was closed. I have now reopened the pull request with the same changes that @ntindle had approved. Could you please review the pull request again?

Ashutoshkataria19 avatar Apr 18 '23 20:04 Ashutoshkataria19

Codecov Report

Patch coverage has no change and project coverage change: -8.51 :warning:

Comparison is base (aedd288) 49.20% compared to head (979d147) 40.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
- Coverage   49.20%   40.69%   -8.51%     
==========================================
  Files          63       63              
  Lines        3014     3015       +1     
  Branches      496      496              
==========================================
- Hits         1483     1227     -256     
- Misses       1411     1716     +305     
+ Partials      120       72      -48     
Impacted Files Coverage Δ
autogpt/memory/pinecone.py 27.90% <0.00%> (-0.67%) :arrow_down:

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 23 '23 23:04 codecov[bot]

@Ashutoshkataria19 This failed the lint check. Please run black . to fix the formatting issues.

Vwing avatar May 01 '23 00:05 Vwing

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 2:27pm

vercel[bot] avatar May 01 '23 14:05 vercel[bot]