SignalK
React 18.3.1, bootstrap 5.3.3, @rjsf/core 5.23.1
Updated with React 18.3.1, bootstrap 5.3.3 and @rjsf/core 5.23.1 support.
Issues
- multiple stylesheet issues
- server-admin-ui/logging throws runtime error:
bootstrap.js:240 Uncaught ReferenceError: Cannot access 'html' before initialization
at bootstrap.js:240:12
at dispatch (redux.mjs:160:1)
at redux-thunk.mjs:7:1
at ws.onmessage (actions.js:170:7)
- server-admin-ui update untested
For me to be able to review this I need to be able to distinguish between changes that have already been merged, like the ts related updates, and what are the actual changes in this PR. The best way to achieve that would be to rebase this branch on master. Is this something you can do? I can assist if needed.
I rebased two days ago (or at least thought I did). If there are additional steps I need to take please let me know what I need to do.
Have you pushed your changes to this branch to your fork of the repository? The commit history now has a lot of commits that are already in master, they should not be there after successful rebase and force push.
I pushed the changes but not force pushed.
Is it too late to force push?
And is it just a matter of executing
git push -f
On Sun, Dec 15, 2024 at 7:05 AM Teppo Kurki @.***> wrote:
Have you pushed your changes to this branch to your fork of the repository? The commit history now has a lot of commits that are already in master, they should not be there after successful rebase and force push.
— Reply to this email directly, view it on GitHub https://github.com/SignalK/signalk-server/pull/1847#issuecomment-2543907047, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAIRDLDQ75U676Y25HCLL2FWLFHAVCNFSM6AAAAABTSUCPM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHEYDOMBUG4 . You are receiving this because you authored the thread.Message ID: @.***>
It is safe (as long as you overwriting the repo with correct content) and yes -f will do it.
Okay. Look for it soon. There's some development cruft in my commits I'd like to remove.
FYI Pretty sure all my changes are in the packages/server-admin-ui and server-admin-ui/dependencies directories and don't collide with other commits.
On Sun, Dec 15, 2024 at 8:56 AM Teppo Kurki @.***> wrote:
It is safe (as long as you overwriting the repo with correct content) and yes -f will do it.
— Reply to this email directly, view it on GitHub https://github.com/SignalK/signalk-server/pull/1847#issuecomment-2543948128, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAIRGYHWTTX2JSHNLWSDD2FWYE5AVCNFSM6AAAAABTSUCPM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHE2DQMJSHA . You are receiving this because you authored the thread.Message ID: @.***>