signoz icon indicating copy to clipboard operation
signoz copied to clipboard

List View for Dashboard

Open Rajat-Dabade opened this issue 1 year ago • 11 comments

Fixes: https://github.com/SigNoz/signoz/issues/3661

Summary by CodeRabbit

  • New Features

    • Introduced enhanced query capabilities for logs and traces, allowing users to filter and search with greater precision.
    • Added a new ExplorerColumnsRenderer component for dynamic column selection and organization in data exploration.
    • Implemented a DataSourceDropdown component that adapts its options based on the exploration panel's context.
    • Enhanced the GridCardLayout and GridPanelSwitch components to support logs data fetching and rendering, improving data visualization.
    • Launched a LogsPanelComponent and a TracesTableComponent for displaying logs and traces in a tabular format, including pagination and detailed views.
  • Enhancements

    • Improved user interface components like QueryBuilder, OrderByFilter, and QBEntityOptions to conditionally render based on the type of query or exploration panel.
    • Updated the WidgetGraph component to include log and trace fields selection, enhancing the customization of data visualization.
  • Style Updates

    • Added new styles for the LogsPanelComponent, ExplorerColumnsRenderer, and TracesTableComponent to ensure a consistent and visually appealing user interface across the application.
  • Bug Fixes

    • Adjusted the cursor style in the TracesExplorer list view for better user experience.

Rajat-Dabade avatar Feb 08 '24 17:02 Rajat-Dabade

We would appreciate it if you could provide us with more info about this issue/pr!

request-info[bot] avatar Feb 08 '24 17:02 request-info[bot]

Walkthrough

The update introduces a list type panel for logs and traces in the dashboard, enabling users to view loglines in both list and table views. This significant enhancement encompasses the addition of new components, props, styles, and modifications across various files to support the functionality, including the integration of a LogsPanelComponent for logs display and adjustments to existing components to accommodate list views and table views with specific configurations.

Changes

Files Change Summary
.../Dashboard/List.tsx, .../Dashboard/Table.tsx, .../Dashboard/TimeSeries.tsx, .../Dashboard/Value.tsx Introduced ListIcon, updated Table to TableIcon, added fillColor props, and SVG adjustments.
.../LogDetail/..., .../Logs/TableView/..., .../constants/panelTypes.ts, .../GridCardLayout/..., .../QueryBuilder/..., .../NewWidget/..., .../container/LogsPanelTable/... Added props for dashboard/list view panels, updated styling, and integrated LogsPanelComponent. Adjusted rendering logic based on new props.
.../container/..., .../hooks/..., .../types/... Enhanced components and hooks to support list and table views, included new types for logs and traces fields.
frontend/src/index.html.ejs Added 'Open Sans' font.

Assessment against linked issues

Objective Addressed Explanation
Option to view logs as listview and table view in the panels (#3661) The changes comprehensively address the objective by introducing components and props to support both list and table views for logs and traces in the dashboard.

Poem

In the realm of data so vast and wide, A rabbit hopped, with eyes open wide. "Logs and traces, in lists, they shall be, Table views too, for all to see."

With a flick of its paw and a twitch of its nose, The dashboard transformed, as the new feature arose. "Behold," it whispered, under the moon's light, "Data in harmony, a truly splendid sight." 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Feb 08 '24 17:02 coderabbitai[bot]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot] avatar Feb 08 '24 17:02 github-actions[bot]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot] avatar Feb 08 '24 17:02 github-actions[bot]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot] avatar Feb 08 '24 18:02 github-actions[bot]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot] avatar Feb 10 '24 19:02 github-actions[bot]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot] avatar Feb 11 '24 08:02 github-actions[bot]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot] avatar Feb 12 '24 12:02 github-actions[bot]

In other type of dashboard (eg:- timeseries, the option to choose datasource is not present) The icons for changing from logs to traces is non intuitive. cc @GeekBoySupreme the column name casing shouldn't be changed i.e location should be location and not Location order by autocomplete doesn't work while scrolling fast, the rendering is slow, i.e there is black space.

In other type of dashboard (eg:- time series, the option to choose data source is not present) ✅ The icons for changing from logs to traces is non-intuitive. cc @GeekBoySupreme (fixed this using dropdown, now we can select log and traces from the QB drop drop) ✅ the column name casing shouldn't be changed i.e location should be location and not Location ✅ order by autocomplete doesn't work ✅ while scrolling fast, the rendering is slow, i.e there is black space. (This issue was related to infinity scroll table, now we use paginated tables). ✅

Rajat-Dabade avatar Feb 13 '24 10:02 Rajat-Dabade

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot] avatar Feb 14 '24 11:02 github-actions[bot]

The colors are not according to design, borders

Screenshot 2024-02-15 at 20 14 34

makeavish avatar Feb 15 '24 14:02 makeavish

two queries seems to be fired when clicking on stage and run, the second one is fired once the first one finishes. full text search doesn't work i.e pasting something and then pressing enter should result in body contains select custom order by and then press next it will result in some API requests getting created and cancelled. I don't see a point of hide , collapse and query name in the list view panel. pagination for order by timestamp is not correct it should use id > and < for pagination and not limit offset In filter not working, eg:- component in xyz doesn't result in correct API request.

  • two queries seem to be fired when clicking on stage and run, the second one is fired once the first one finishes. (known issue, will take care in subsequent PR, not a blocker https://github.com/SigNoz/signoz/issues/4572) ✅
  • full-text search doesn't work i.e pasting something and then pressing enter should result in a body contains
  • select custom orderby and then press next it will result in some API requests getting created and cancelled. (Not a blocker will take care of this as a part of https://github.com/SigNoz/signoz/issues/4572) ✅
  • pagination for order by timestamp is not correct it should use id > and < for pagination and not limit offset. ✅
  • In filter not working, eg:- component in xyz doesn't result in correct API request. (Verified with @nityanandagohain working as expected) ✅

Rajat-Dabade avatar Feb 19 '24 14:02 Rajat-Dabade

@Rajat-Dabade please push the new commits so that I can check!

nityanandagohain avatar Feb 19 '24 15:02 nityanandagohain

for order by timestamp.

  • next should use id < , which means older logs.
  • previous should use id >, which means newer logs.

right now it's opposite.

@nityanandagohain done ✅, Please check.

Rajat-Dabade avatar Feb 19 '24 16:02 Rajat-Dabade