signoz icon indicating copy to clipboard operation
signoz copied to clipboard

[Fix]: Using exported dashboards as input to dashboard provisioning

Open Haavasma opened this issue 1 year ago • 9 comments

There is a mismatch between exporting dashboard and using them to auto provision dashboards when instantiating signoz.

https://github.com/SigNoz/signoz/issues/3595

This PR includes the "uuid" as part of the data field in dashboards when exporting, such that when the exported file is used for automatic provisioning in pkg/query-service/app/dashboards/provision.go the "uuid" is present, prohibiting issue with [interface is nil](panic: interface conversion: interface {} is nil, not string) when using the raw exported json during provisioning, as the missing "uuid" field will be present.

Haavasma avatar Sep 21 '23 14:09 Haavasma

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

welcome[bot] avatar Sep 21 '23 14:09 welcome[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 21 '23 14:09 CLAassistant

@palashgdev this one easy, pelase take a look

srikanthccv avatar Sep 29 '23 16:09 srikanthccv

Any updates on this?

Haavasma avatar Oct 05 '23 21:10 Haavasma

@palashgdev/@YounixM please review the frontend change.

srikanthccv avatar Oct 06 '23 01:10 srikanthccv

Bump on this, put an exported dashboard into the folder thinking it would work and ended up taking down my signoz instance for a bit.

ImVexed avatar Nov 01 '23 03:11 ImVexed

@Haavasma can you please resolve the conflicts?

srikanthccv avatar Nov 01 '23 03:11 srikanthccv

@Haavasma sorry I missed the last update. Are you still interested in continuing this? It's an important fix and I'd would like to see this get merged.

srikanthccv avatar Feb 08 '24 17:02 srikanthccv

Yes, i'm gonna go over it again since it's been a while (possibly tomorrow) I'll notify you if it's ready from my perspective

Haavasma avatar Feb 08 '24 18:02 Haavasma

Yes, i'm gonna go over it again since it's been a while (possibly tomorrow) I'll notify you if it's ready from my perspective

@Haavasma I created another PR based on your PR with the conflicted solved, if you don't mind https://github.com/SigNoz/signoz/pull/4726

wbtan7 avatar Mar 20 '24 17:03 wbtan7

Ahh great, sorry, totally forgot about this :(

Haavasma avatar Mar 20 '24 17:03 Haavasma

Superseded by https://github.com/SigNoz/signoz/pull/4726

srikanthccv avatar Mar 26 '24 18:03 srikanthccv