signoz
signoz copied to clipboard
[Fix]: Using exported dashboards as input to dashboard provisioning
There is a mismatch between exporting dashboard and using them to auto provision dashboards when instantiating signoz.
https://github.com/SigNoz/signoz/issues/3595
This PR includes the "uuid" as part of the data
field in dashboards when exporting, such that when the exported file is used for automatic provisioning in pkg/query-service/app/dashboards/provision.go
the "uuid" is present, prohibiting issue with [interface is nil](panic: interface conversion: interface {} is nil, not string)
when using the raw exported json during provisioning, as the missing "uuid" field will be present.
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗
@palashgdev this one easy, pelase take a look
Any updates on this?
@palashgdev/@YounixM please review the frontend change.
Bump on this, put an exported dashboard into the folder thinking it would work and ended up taking down my signoz instance for a bit.
@Haavasma can you please resolve the conflicts?
@Haavasma sorry I missed the last update. Are you still interested in continuing this? It's an important fix and I'd would like to see this get merged.
Yes, i'm gonna go over it again since it's been a while (possibly tomorrow) I'll notify you if it's ready from my perspective
Yes, i'm gonna go over it again since it's been a while (possibly tomorrow) I'll notify you if it's ready from my perspective
@Haavasma I created another PR based on your PR with the conflicted solved, if you don't mind https://github.com/SigNoz/signoz/pull/4726
Ahh great, sorry, totally forgot about this :(
Superseded by https://github.com/SigNoz/signoz/pull/4726