signoz icon indicating copy to clipboard operation
signoz copied to clipboard

Published 20 hours ago • verified publisher icon SigNoz

Query range caching

Open srikanthccv opened this issue 2 years ago • 2 comments

srikanthccv avatar Jan 30 '23 00:01 srikanthccv

We would appreciate it if you could provide us with more info about this issue/pr!

request-info[bot] avatar Jan 30 '23 00:01 request-info[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
30.1% 30.1% Duplication

sonarqubecloud[bot] avatar Jan 31 '23 05:01 sonarqubecloud[bot]

@mindhash I noticed lately that there are minor differences in how rule queries are run and evaluated. I believe they can make use of the same querier interface. I am refactoring this to accommodate that.

srikanthccv avatar Feb 01 '23 02:02 srikanthccv

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 43 Code Smells

No Coverage information No Coverage information
20.6% 20.6% Duplication

sonarqubecloud[bot] avatar Mar 06 '23 02:03 sonarqubecloud[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 21 '23 07:04 CLAassistant

@srikanthccv taking a look. Will get back soon

mindhash avatar Jun 09 '23 08:06 mindhash

@mindhash I split this into smaller ones since I made the last comment. Please review this instead https://github.com/SigNoz/signoz/pull/2782. Also we are initially planning for enabling for dashboards so the prev may not be relevant but I would still appreciate if you have any feedback or suggestions.

srikanthccv avatar Jun 09 '23 09:06 srikanthccv

Addressed the comments, PTAL.

srikanthccv avatar Sep 06 '23 05:09 srikanthccv