signoz
signoz copied to clipboard
Feat(FE): Global Time Visibility as per route
Is your feature request related to a problem?
Please describe. Right now to show the global header we are using routesToSkip , need to refactor the logic to display according to the route where this component is required
eg:
routes = ['/services','/service/:id','/trace','/logs','/dashboard/:dashboardId','/exceptions','/service-map']
Describe the solution you'd like
we can keep an array of routes in which the header needs to disable
Thank you for your feature request – we love each and every one!
Can I pick up this issue ? @palashgdev
Yeah Sure @hussamkhatib
hey @palashgdev, I think the issue is already resolved. ref: https://github.com/SigNoz/signoz/pull/1669/files#diff-97e3d07d47e0a86ba7fbf9e2f446e16910c7e526fb285072517db01675d4a5a2
no @hussamkhatib still we are displaying dropdown based on the route which we have to skip
as we need to handle were we have to show the dropdown
@hussamkhatib @palashgdev can i take this issue ?
@himanshugupta714 Missed your comment somehow. I'm not sure if you would still want to work on it, I closed my PR due to inactivity.