react-native-tor icon indicating copy to clipboard operation
react-native-tor copied to clipboard

Mac Catalyst

Open marcosrdz opened this issue 4 years ago • 10 comments

Unable to compile with Mac Catalyst

Showing All Messages Building for Mac Catalyst, but linking in dylib built for iOS Simulator, file 'Documents/GitHub/BlueWallet/node_modules/react-native-tor/ios/Libsifir_ios.framework/Libsifir_ios' for architecture x86_64

marcosrdz avatar Jan 08 '21 20:01 marcosrdz

Zero testing was done on Catalyst. Focus was really iOS.

gabidi avatar Jan 08 '21 22:01 gabidi

Is there documentation that I can follow in order to tackle this?

marcosrdz avatar Jan 11 '21 03:01 marcosrdz

@marcosrdz you probably want "Development and Building from Scratch" section from README, it has instructions on how to build rust code, then ios code, then typescript code

Overtorment avatar Jan 11 '21 11:01 Overtorment

Hey @marcosrdz Thanks for offering to tackle this!

I'm not really well versed in Catalyst and thus not exactly sure what the error means, If you can give me your insight I would be able to better point you in the correct direction relative to this repo.

That said, from my limited understanding of the cryptic message seems like it's looking for an architecture that it's not finding or incorrectly linking to (?). It could be simply that something needs to be added to the dylib headers or the Info.plist of the framework, if so this is done here: https://github.com/Sifir-io/sifir-rs-sdk/blob/main/sifir-ios/scripts/into_framework.sh#L31-L59

Again if you would give me more context on what the error means relative to Catalyst I would probably be able to give you better information.

Thanks again! G

gabidi avatar Jan 11 '21 12:01 gabidi

https://github.com/BlueWallet/BlueWallet/pull/2487

I have this branch ready to build so you can see the same error as I do. Run: npm run maccatalystpatches Open xcode, change the destination from an iPhone sim to "my mac" and press Run

marcosrdz avatar Jan 11 '21 16:01 marcosrdz

https://stackoverflow.com/questions/58916615/how-do-i-build-for-mac-catalyst-x86-64-apple-ios-macabi

additional info

marcosrdz avatar Jan 11 '21 23:01 marcosrdz

Will try building for this target, but considering it's Tier2 , i'm keeping my fingers crossed that dependencies used in the rs-sdk will build. I'll keep you posted. Thanks !

gabidi avatar Jan 12 '21 21:01 gabidi

Looks like This has been added as Tier3 on main channel Rust 1.5.0 https://github.com/rust-lang/rust/pull/77484

Should be able to compile for this target now without too much trouble

Will add todo.

gabidi avatar Feb 28 '21 13:02 gabidi

Any update on this issue?

marcosrdz avatar Apr 29 '21 14:04 marcosrdz

on todo, Based on a number community requests I'm working on hidden services part of the module. That said if anyone wants to take a stab at this in the meantime, please do!

gabidi avatar May 07 '21 12:05 gabidi