sielo-legacy icon indicating copy to clipboard operation
sielo-legacy copied to clipboard

Missing `make install`.

Open dreirund opened this issue 4 years ago • 2 comments

Making a clean system-wide install (e.g. via a package manager) is quite difficult: The Makefile which gets generated by cmake misses a statement to do something make install-like.

While it is still quite easy to manually copy bin/sielo-browser and the other files at bin/, and a bit more complicated but still possible to copy the files at icons/, I have no clue where to copy the stuff under data/ (plugins, themes, etc.) to to have it system-wide available and automatically found by sielo-browser.

Please add a proper make install-functionality.

dreirund avatar Aug 30 '19 11:08 dreirund

I'm not sure to understand what you mean... 😅

If you talk about Linux related package files (icons, license) you should copy them in the standard way given by the package manager. If you talk about Sielo specifics stuff (like themes and plugins), you don't even have to copy them. Sielo will do it itself when it will run if they are not in place. You just have to make sure the data folder exist during the build.

Feldrise avatar Aug 30 '19 11:08 Feldrise

I'm not sure to understand what you mean...

Have the build system ship a way to install stuff in a manner that is consistent with usual standard directories (and honouring the install prefix set during cmake) and keeps track to install stuff to places where sielo will find it's data.

If you talk about Sielo specifics stuff (like themes and plugins), you don't even have to copy them. Sielo will do it itself when it will run if they are not in place.

I

  • build Soelo,
  • install Sielo,
  • delete the build directory.

Where will it copy it from?

You just have to make sure the data folder exist during the build.

Does it mean it will be compiled in statically in libSieloCore.so or sielo-browser? That's why it is so big. And not very nice ... )-:.

dreirund avatar Aug 31 '19 06:08 dreirund