SiEPIC-Tools icon indicating copy to clipboard operation
SiEPIC-Tools copied to clipboard

Suggest to add a second WAVEGUIDES.xml file for custom waveguide

Open JinWallner opened this issue 3 years ago • 5 comments

Hi,

Can we add a second WAVEGUIDES.xml file, e.g. WAVEGUIDES_custom.xml for custom waveguide configuration? Currently, custom waveguides and PDK waveguides share the same file. It needs to be remerged for every new PDK release.

Thanks,

Jin

JinWallner avatar Jul 06 '21 16:07 JinWallner

Good idea, perhaps instead of importing WAVEGUIDES.xml we should just import every xml file containing "WAVEGUIDE".

mustafacc avatar Jul 06 '21 16:07 mustafacc

I have implemented this. I loads WAVEGUIDES.xml and then all WAVEGUIDE_*.xml files. It is on GitHub, but not released in Package Manager. Can you please check?

lukasc-ubc avatar Jul 08 '21 01:07 lukasc-ubc

Works okay for EBeam but there seems to be issues with AMF and AIM

AMF: generated waveguides missing pinrec layers + asterisk image

AIM: waveguides don't generate properly image

mustafacc avatar Jul 08 '21 04:07 mustafacc

Hi Mustafa, Thanks for checking. I don’t see this problem on my end. Let me investigate further.

lukasc-ubc avatar Jul 08 '21 05:07 lukasc-ubc

I found an issue where a string representation of the bezier parameter caused the waveguide to not generate. Just fixed. Before updating, can you check if this problem only occurred for Bezier curve waveguides? i.e., you shouldn't have had this issue with non-bezier waveguides (e.g., TM).

lukasc-ubc avatar Jul 08 '21 07:07 lukasc-ubc