pixi-essentials icon indicating copy to clipboard operation
pixi-essentials copied to clipboard

Unable to compile project using this lib because it's not passing Typescript 4 checks

Open Friksel opened this issue 2 years ago • 3 comments

There is an issue in the lib that, after doing some research on Typescript, wasn't an issue with Typescript 3 compiler, but is with Typescript 4 (https://stackoverflow.com/questions/63750710/ts2611-foo-is-defined-as-a-property-in-class-a-but-is-overridden-here-in)

image

I'm working in Javascript myself, but the document builder I use to build documents for projects is using Typescript 4. Which is now stopping at the issue making the project build to fail because of this issue in the lib. For now I downgraded the project to use the old Typescript 3, but that's obviously not the preferred solution.

Could this issue either be solved? And could you perhaps please upgrade to Typescript 4 to have the latest checks in place? That would be awesome!

Friksel avatar Apr 17 '22 18:04 Friksel

I'm seeing a lot of issues coming from you @Friksel. You've got 2 options:

  • I've opened up GitHub Sponsors so you can post a $25 bug bounty for these types of issues (if I add the label) and you'll get the published fix in 24hrs: https://github.com/sponsors/ShukantPal?frequency=one-time
  • Open a PR yourself :)

ShukantPal avatar Apr 17 '22 21:04 ShukantPal

@ShukantPal you act like I mention luxery things while in reality taking a lot of time to work around issues and add feedback and suggestions on these issues and help you test them out on the lib, which took a lot of my time and still most of it needed workarounds. People helping you test and mention issues is also standing for lots of value and if you'd know my hourly rate and the time I spent on you lib you might perhaps appreciate it a little more instead of acting like it's all moving one direction and asking for money to fix issues you introduced yourself.

Indeed this particular issue isn't really a big issue, so for this I understand your stand point, but most other issues I mentioned here are and there seem to be no intention whatsoever to fix it.

I think you should ask yourself why you'd like to make money out of fixing issues you introduced yourself on an open source lib and why you decided to quit fixing things. Even if you know exactly what to change and it's only 3 lines of code, you still refuse to enter it, like the interactivity thing where you promised to fix it and still refused to copy'n'paste the fix code that was fully tested. So why should I even try to open a PR if you're not passionate about your lib to be without issues?

Thanks for the things you helped with, but without maintenance on known bugs I see no other way than to consider this project dead now. And if every issue cost me 25 dollars than it would be a very expensive thing.

Good luck with your project. I'll start my own now.

Friksel avatar Apr 19 '22 11:04 Friksel

If you think starting you're own project is cheaper (or gets you more hourly billing), go ahead - more money to you. Being passionate about this project does not mean doing free work or giving consulting like you've asked for advice in other posts. I'll fix these issues when I feel like coming back to this project.

Addendum: If you're working for someone else, ask them to pay for open source fixes.

Even if you know exactly what to change and it's only 3 lines of code, you still refuse to enter it, like the interactivity thing where you promised to fix it and still refused to copy'n'paste the fix code that was fully tested. So why should I even try to open a PR if you're not passionate about your lib to be without issues?

Seems like you gotten a whole lot of free advice on what 3 lines to add right. I mentioned it in that post but that wasn't a bug, interactivity wasn't implemented for a reason. I said I'd publish a fix if the 3 lines didn't work for you, but they did.

ShukantPal avatar Apr 19 '22 12:04 ShukantPal