Shubhdeep Singh comments

Results 29 comments of


                                            Shubhdeep Singh

@artursouza please review the PR

@cicoyle i'll just open a new PR keeping above suggestions in check

hey!!! @AnonSar Is the issue still open ????

Thanks @spzala was just about to do..

Hey @jmhbnz i have rebased the commits please take a look into it.

@jmhbnz I guess they aren't part of the changed file but some self generated version update file. So should they be squashed?

@jmhbnz i have rebased the previous commits into a single commit as you told me you can check it above

@jberkus Sorry for the delay.......was busy in my placement season So should I raise a new PR with the same commit or is there any other way around?

Hii!! Is this issue still open by any chance??