RCTRefreshControl icon indicating copy to clipboard operation
RCTRefreshControl copied to clipboard

React-Native 0.16.0: 'RCTSparseArray.h' file not found

Open ivanbrens opened this issue 9 years ago • 11 comments

According to some highlights of the release here: http://www.reactnative.com/react-native-v0-16-0-rc-and-v0-15-0-released/

RCTSparseArray was replaced by NSDictionary.

Will you upgrade?

ivanbrens avatar Dec 05 '15 22:12 ivanbrens

+1

plrthink avatar Dec 07 '15 08:12 plrthink

@DickyT — I'm looking into fixing this issue. Your repo doesn't have an issues page, but the plan is to submit a PR to your repo. Sound good?

rreusser avatar Dec 09 '15 20:12 rreusser

@rreusser that will be great, thx!

DickyT avatar Dec 10 '15 01:12 DickyT

Thanks! @rreusser @DickyT

alvinwoon avatar Dec 11 '15 09:12 alvinwoon

I got sidetracked because we ran into like fifty problems when we upgraded to RN 0.16 and ended up downgrading until some things are straightened out, but I'll test this out today.

For anyone wondering, it appears it really might just be as simple as running s/RCTSparseArray/NSDictionary/g on the file. It appears it's just a change in argument type with no change in behavior, correct?

See: https://github.com/Shuangzuan/RCTRefreshControl/blob/master/RCTRefreshControl.m#L27-L29

rreusser avatar Dec 11 '15 12:12 rreusser

@rreusser I think you are correct.

PS. I just answered the wrong stuff and I deleted one response, never mind if you guys see an email

DickyT avatar Dec 12 '15 07:12 DickyT

@rreusser - Your repo works! :+1: But the npm version is outdated, so could you push the new version online?

Thanks! You too @DickyT

richarddewit avatar Dec 17 '15 14:12 richarddewit

UIRefreshControl have been added to core since 0.16.0. https://github.com/facebook/react-native/pull/4205

samuelkraft avatar Dec 17 '15 15:12 samuelkraft

@samuelkraft - Cool, but I like the refresh-thingy from this module better though

richarddewit avatar Dec 17 '15 15:12 richarddewit

replace

RCTSparseArray *viewRegistry

with

NSDictionary<NSNumber *, UIView *> *viewRegistry 

bakso avatar Dec 31 '15 12:12 bakso

Just use my fork version here.It seems that this repo is not under mantainess any more.The fork version will keep update to latest react-native version. @richarddewit @ivanbrens @plrthink and you can use

$ npm install react-native-drop-refresh

to install that npm package.It's now compatible with react-native 0.20.0

Obooman avatar May 31 '16 12:05 Obooman