Shridhar Goel

Results 64 comments of Shridhar Goel

@divyansh-dxn Is there a reason for not using `CoroutineExceptionHandler`?

@dae has provided some good advice, it would be better to rewrite this flow instead of trying to migrate to coroutines using the existing code.

@divyansh-dxn Okay, you can add them in the cleanup then. > Message ID: ***@***.***> >> >

Conflicts need to be resolved.

## Proposal ### Please re-state the problem that we are trying to solve in this issue. We need to combine text and dropdown icon for dropdowns buttons. ### What is...

## Proposal [Updated](https://github.com/Expensify/App/issues/39832#issuecomment-2043214850) to remove extra padding. Now, it will look like medium button.

The selected proposal mentions this: ``` iconRight={() => } ``` This would lead to performance issues because of unnecessary re-renders. I've mentioned the correct way [here](https://github.com/Expensify/App/issues/39832#issuecomment-2043214850). So, can you check...

@luacmartins @arosiclair Kindly check this comment before finalising: https://github.com/Expensify/App/issues/39832#issuecomment-2052312784

> Verify that the routes for Group participants invites, participant details, and role selection works as expected. Test corner cases like deep link, etc. Does this mean manual verification or...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Add tests for getGroupChatName() to verify that it is working correctly. ### What is...