Shridhar Goel
Shridhar Goel
> the dependency injection in LoadPronunciationActivity is useless as the dispatchers are not used @lukstbit What do you mean by this? Aren't they being used inside the activity?
The plan here is to use dependency injection at more places in the app and not only limiting it to coroutine dispatchers.
> this will increase build time We're already using `annotationProcessor`, so isn't it already factored in?
> as we get one injection This is only for the initial PR. Further changes would be there in different pull requests.
It would be better to use a more descriptive PR title and commit message which indicates that you have changed the cursor colour to white.
Will this change not cause unintended changes at other places?
@pratyaksh1610 It should be fine since `textColorPrimary` and `textColorSecondary` are also set as white.
This change is in ActionBarStyle, so shouldn't affect those components. On Thu, Sep 8, 2022, 22:07 Brayan Oliveira ***@***.***> wrote: > FYI, colorControlActivated changes switches, dialogs details, progress bar >...
Wiki page for introduction slides: https://github.com/ankidroid/Anki-Android/wiki/Introduction-slides-for-new-user-onboarding Wiki page for feature prompts: https://github.com/ankidroid/Anki-Android/wiki/Onboarding-feature-prompts-for-new-users These are the initial versions of these pages, they might be updated later to include more information.
@ujjwalagrawal17 Yes, sure.