DiffusionDet icon indicating copy to clipboard operation
DiffusionDet copied to clipboard

[A Bug?] The diffused boxes as input may have negative coordinates.

Open YTEP-ZHI opened this issue 2 years ago • 2 comments

https://github.com/ShoufaChen/DiffusionDet/blob/1efb36d4b0b721f2d509bc72656235a94d73ab02/diffusiondet/detector.py#L400-L403

Though you clamped the coordinates (x) at line400, they may become negative number when converted from (cx, cy, w, h) to (x, y, x, y) mode. Here is an example:

image

It happens when cx or cy is close to zero (or clamped to zero), if conducting cx - w/2 or cy - h/2, it becomes negative number.

Is it acceptable to pass the negative coordinates to the RCNN head? Will it cause any unexpected behavior extracting roi feature?

YTEP-ZHI avatar Dec 14 '22 09:12 YTEP-ZHI

Hi,

Thanks for your interest.

Yes, the RCNN head can accept negative coordinates.

ShoufaChen avatar Dec 15 '22 10:12 ShoufaChen

Thanks for your reply.

YTEP-ZHI avatar Dec 20 '22 14:12 YTEP-ZHI