themekit
themekit copied to clipboard
Theme download cannot download live settings_data.json
when i run theme download config/settings_data.json --live --no-ignore -v
on a theme with an outdated settings_data.json file it returns:
[development] Skipped config/settings_data.json (Checksum: 09f9535a9b6a64892140d5fb41a6447a)
[development] 1 files, No Change: 1
Implying that the settings_data.json files are the same, when they are not
To Reproduce Steps to reproduce the behavior:
- run command 'theme download config/settings_data.json --live --no-ignore -v' on theme_id which has an outdated
settings_data.json
file
Expected behavior
settings_data.json
would download from live theme, this would be really useful in theme development to quickly have section settings match that of live site, rather than having to do it manually
Environment (please complete the following information):
- OS : macOS 11.1
- Themekit version: ThemeKit 1.1.6 darwin/amd64
- Editor: Vim (Iterm2)
I cannot reproduce it with the following commands:
-
theme download config/settings_data.json --live --no-ignore -v
-
theme download config/settings_data.json --no-ignore -v
-
theme download config/settings_data.json -v
Every time my outdated settings_data.json
is overwritten with the latest version from Shopify.
Environment:
- OS: Windows 10
- ThemeKit version: ThemeKit 1.1.6 windows/amd64
- Editor: Visual Studio Code
So there is probably an issue with the macOS version of ThemeKit. Maybe someone with a mac can verify.