themekit icon indicating copy to clipboard operation
themekit copied to clipboard

Verbose says the ignored file is updated but actually, it is not

Open Youhan opened this issue 5 years ago • 1 comments

Describe the bug Verbose says the ignored file is updated but actually, it is not

To Reproduce Steps to reproduce the behavior:

  1. Change a theme settings
  2. run command theme deploy -d "dist" --nodelete --verbose --store ${DEPLOY_STORE} --password ${DEPLOY_PASSWORD} --themeid ${DEPLOY_THEME_ID} --allow-live --ignored-file "config/settings_data.json" --env=production
  3. verbose log says [production] Updated config/settings_schema.json
  4. check the website and you see the file is not updated.

Expected behavior It should say the file is ignored/skipped

Environment (please complete the following information):

  • OS [e.g. iOS]:
  • Themekit version (run theme version to check): 1.1.1
  • Editor [e.g. atom, sublime]:
  • Ignore:

Additional context Add any other context about the problem here.

Youhan avatar Nov 26 '20 20:11 Youhan

The flag is ignore_files and not ignored-file https://shopify.github.io/themekit/configuration/ I just tested this and for some reason themekit will not tell you that it is an invalid flag if you provide a value to it. But the problem you are experiencing is because you are not using the correct flag

tanema avatar Nov 27 '20 15:11 tanema