themekit icon indicating copy to clipboard operation
themekit copied to clipboard

Request timeout always

Open EHLOVader opened this issue 5 years ago • 11 comments

When running theme download

To Reproduce Steps to reproduce the behavior:

  1. run command 'theme download' in previously working shopify theme
  2. or run command 'theme get --list' with password for new theme to find themeid

Expected behavior It should download and work however I'm seeing it timeout every time. Increased the timeout in the config for the existing site and even at a rediculous timeout it fails.

Attempted to upgrade from 1.0.2 if there is another but it also times out at TLS handshake

Updating from 1.0.2 to latest
Get https://shopify-themekit.s3.amazonaws.com/releases/latest.json: net/http: TLS handshake timeout

Environment (please complete the following information):

  • OS MacOS Catalina 10.15.2
  • Themekit version 1.0.2

similar to #665 but they occasionally got it to work. I have not had any success.

EHLOVader avatar Feb 06 '20 15:02 EHLOVader

Okay it seems like there is an issue with our connection to our S3 instance I will ask around about it

tanema avatar Feb 06 '20 15:02 tanema

Also this seems like a duplicate of https://github.com/Shopify/themekit/issues/681 because it is the S3 check at startup that is taking a long time at start up and not the requests to shopify

tanema avatar Feb 06 '20 15:02 tanema

@tanema Thanks, I didn't know if I should comment in those threads or start my own. Seemed slightly different enough and as though much time had passed since then.

I didn't know it checks for updates at startup. That would probably do it. I tried running commands in verbose but it didn't output a thing so I figured it had to have been the first things it was trying.

EHLOVader avatar Feb 07 '20 19:02 EHLOVader

I asked our aws people and nothing was wrong with the bucket for updates so I am not sure why you would be getting this issue. Is it still broken?

tanema avatar Feb 07 '20 21:02 tanema

Thanks for looking into it @tanema, unfortunately I am still getting the timeout. Was there a way I could create debug information for you to help track down the problem?

EHLOVader avatar Feb 13 '20 15:02 EHLOVader

Try running it with the --no-update-notifier flag and that will pass the update check I believe. I will release a version soon without the version checking

tanema avatar Feb 13 '20 15:02 tanema

That is odd. Even with that flag it doesn't want to work. -v doesn't output any more detail either. I ran into this problem because I was trying to get a theme for the first time from a new site but this happens on a site which I've had success with in the past and has a config.yml already.

EHLOVader avatar Feb 14 '20 15:02 EHLOVader

Do you still get the timeout above? From amazon? Or from shopify?

tanema avatar Feb 24 '20 19:02 tanema

I just tested and yes I am. I will try testing on another machine, I don't know what might be misconfigured here but I can't imagine it is broken for everyone for this long. Luckily I don't need to make any major changes right now, but I am concerned if I do have to it won't work. Regarding your questions about from amazon or shopify, it appears to be shopify, I get a timeout when running a get list for themes or download. and I've tried --no-update-notifier with no difference in the result.

EHLOVader avatar Feb 26 '20 20:02 EHLOVader

I am getting this same error.

Specifically when I run the command:

 theme get --list -p=[your-password] -s=[you-store.myshopify.com]

I get the following error:

request timed out. if you are receive this error consistently, try increasing the timeout in your       config

I have tried to create a configuration file in order to increase the timeout. Unfortunately the theme get --list command ignores any timeouts set in the configuration file.

Help please.

Bill

wernet avatar Mar 24 '20 21:03 wernet

I may have an update, but don't know if it is helpful. I still have this issue, on my machine, but had a colleague test it on their machine and they are able to get the shopify theme commands to work.

I don't know what is different in our two machines because we use many of the same software and tools. But it is at least a difference that is noteworthy.

EHLOVader avatar Apr 30 '20 13:04 EHLOVader