theme-tools icon indicating copy to clipboard operation
theme-tools copied to clipboard

Blocks should be able to use itself as a child block target in schemas

Open aswamy opened this issue 10 months ago • 1 comments

Describe the bug

  • Block type completion should not allow itself as a completion option

  • Theme check should warn us when we try to use a block within itself

  • Bonus: Should we also warn when we see a circular block dependency?

Source Image

Expected behaviour

  • blocks and presets.[].blocks.[].type should not include itself as an option
  • theme check should warn us when a block uses itself as a child block in its schemas

Actual behaviour

  • vscode completion offers the block itself as an option
  • no theme check error

aswamy avatar Feb 04 '25 15:02 aswamy

@charlespwd This is the circular issue i was talking about. Should i just close this since we should be able to do this?

aswamy avatar Feb 10 '25 22:02 aswamy

I mean... a group should be able to have child groups 🤔 Probably good to close?

charlespwd avatar May 02 '25 15:05 charlespwd