theme-tools
theme-tools copied to clipboard
[vscode extension] Profile annotations and webview
What are you adding in this PR?
Command to call out to shopify theme profile (https://github.com/Shopify/cli/pull/5109) which will
- Put profile annotations (vscode "decorations") in the relevant files
- Show a webview with the speedscope profile, similar to if the command was run from
shopify theme profile
Here's the error if shopify theme profile fails to execute (for example, CLI version is not up to date or not authenticated)
What's next? Any followup issues?
Very much a v1, I think we can improve a few ways from here
- Ability to clear the annotations.
- Better resiliency regarding calling shopify CLI (open to suggestions).
- Interactivity between the webview profile and the code.
- Better UX around calling the command.
Before you deploy
Public API changes, new features
- [x] I included a minor bump
changeset - [x] My feature is backward compatible
I'm converting this back to draft because there's these things we need to worry about:
- Am I profiling the code I'm looking at?
- How do we deal with VS Code workspaces?