theme-tools icon indicating copy to clipboard operation
theme-tools copied to clipboard

shopifyCLIPath doesn't respect locally installed CLI

Open texastoland opened this issue 2 years ago • 0 comments

Problem

"shopifyLiquid.languageServerPath": "./node_modules/.bin/shopify" configuration doesn't work.

Solution

  1. LanguageClient needs initialized with {...serverOptions, options: {cwd: getItFromVSCode()}}.
  2. My second thought is ideally options.env.PATH should be prefixed with ./node_modules/.bin as a best practice to prefer devDependencies over global installation.

texastoland avatar Nov 22 '23 04:11 texastoland