theme-tools icon indicating copy to clipboard operation
theme-tools copied to clipboard

Not respecting `ignore` list on checks

Open madsenmm opened this issue 5 months ago • 3 comments

This is my .theme-check.yml fil in the repo.

root: src

RemoteAsset:
  enabled: true
  ignore:
    - snippets/head-assets.liquid
    - snippets/video.liquid
    - snippets/image.liquid

But still getting these warnings when running the workflow Image

This is the config for the workflow

- name: Theme Check
        uses: shopify/theme-check-action@v2
        with:
          theme_root: './src'
          flags: '--fail-level warning'
          token: ${{ github.token }}
          base: main

madsenmm avatar Jul 09 '25 10:07 madsenmm

This issue seems to be related to https://github.com/Shopify/theme-tools/issues/1006

karreiro avatar Jul 21 '25 09:07 karreiro

This works for me within the editor. I suspect there's a problem because the root property is qualified twice with theme_root & the config file.

What happens if you remove theme_root?

charlespwd avatar Sep 24 '25 13:09 charlespwd

What could also be done is leave the config as is and move .theme-check.yml in src and remove the root: src from the config file.

❌ instead of this

root/
  .theme-check.yml
  src/

✅ try this

root/
  src/
    .theme-check.yml

charlespwd avatar Sep 24 '25 13:09 charlespwd